Expose gen_oplist_lib to clients #11231
Conversation
Summary: I'm working on a linter that checks a model's ops against those available in our runtime environment (see D75110565), and I'd like to call `gen_oplist` programmatically. I can't do that because `gen_oplist_lib` is not visible outside the `executorch` subdir. If there are no objections, I'd like to expose it to clients. Differential Revision: D75630096
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11231
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 07c3daa with merge base 1f697f0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75630096 |
Vysarat
added
topic: not user facing
release notes: none
| base_module = "executorch.codegen.tools", | ||
| visibility = [ | ||
| "//executorch/...", | ||
| "@EXECUTORCH_CLIENTS", |
There was a problem hiding this comment.
Im fine with this but you want a yaml? Would it be better if you refactored to take a dep on an in memory represenation?
@larryliu0820 Is this representation stable for people outside ET to take a dep?
There was a problem hiding this comment.
I agree that skipping the yaml would make things cleaner. I think that can be fixed in a follow-up PR.
There was a problem hiding this comment.
Agreed let's do the hard work of exposing an API that returns the object in memory. Instead of a follow-up, can you do it first and it becomes clear on what library/target to expose publicly?
There was a problem hiding this comment.
Also just in general it seems like all you'd need are the dtype dim order combinations for every op
|
Hi @Vysarat! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
4 participants
Summary: I'm working on a linter that checks a model's ops against those available in our runtime environment (see D75110565), and I'd like to call
gen_oplistprogrammatically. I can't do that becausegen_oplist_libis not visible outside theexecutorchsubdir. If there are no objections, I'd like to expose it to clients.Differential Revision: D75630096